Ruby: Make links in CS section more descriptive #28315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using the controversial "history of Git and GitHub" video, this replaces it to have a link to GitHub's official docs on how Git and GitHub work together.
|
Definitely sure that those linting issues were already there... 🤨🤨🤨 |
JoshDevHub
requested changes
Jun 30, 2024
| @@ -22,7 +22,7 @@ This section contains a general overview of topics that you will learn in this l | |||
| <div class="lesson-content__panel" markdown="1"> | |||
| 1. Watch [Introduction to Algorithms by David Malan](https://www.youtube.com/watch?v=6hfOvs8pY1k) on TedEd to see how to think about algorithms. | |||
| 2. Watch [What is an Algorithm?](https://youtu.be/e_WfC8HwVB8) on YouTube for a more structured look at solving problems using algorithms. | |||
| 3. Read [this Quora answer about the importance of algorithms in web development](https://qr.ae/py3NAc) to get some context for why we're going over this stuff. | |||
| 3. Read this Quora answer about [the importance of algorithms in web development](https://qr.ae/py3NAc) to get some context for why we’re going over this stuff. | |||
There was a problem hiding this comment.
Suggested change
| 3. Read this Quora answer about [the importance of algorithms in web development](https://qr.ae/py3NAc) to get some context for why we’re going over this stuff. | |
| 3. Read this Quora answer about [the importance of algorithms in web development](https://qr.ae/py3NAc) to get some context for why we're going over this stuff. |
Just a small suggestion here to keep the apostrophe character as ' (which we use throughout the curriculum) rather than ’ (which I guess is how it's formatted in Google Docs maybe? And that made it over in copy/paste)
I got you. Went ahead and fixed all other linting in those files in addition to the apostrophe change you suggested. Should be good now! |
JoshDevHub
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
As per what I was assigned in the issue below, this fixes the links in "A Very Brief Intro to CS", "Recursive Methods", and "Project: Recursion" to be more descriptive.
This PR
Issue
Related to #28290
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection