Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods lesson: Provide descriptive link text #28310

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

CJKbarts
Copy link
Contributor

@CJKbarts CJKbarts commented Jun 29, 2024

Because some links in the lesson were either too verbose or too concise. These changes make the lesson easier to follow

This PR

Issue

Related to #28290

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby Involves the Ruby course label Jun 29, 2024
@CJKbarts CJKbarts changed the title Provide descriptive link text to methods lesson of 'basic ruby' section Methods lesson: Provide descriptive link text Jun 29, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these and also fixing up the lint errors. Just a couple of small changes below then we should be good to merge!

ruby/basic_ruby/methods.md Outdated Show resolved Hide resolved
ruby/basic_ruby/methods.md Outdated Show resolved Hide resolved
ruby/basic_ruby/methods.md Outdated Show resolved Hide resolved
@CJKbarts
Copy link
Contributor Author

I think I got everything. I had some problems trying to squash the new commit into the old one but I think I got it.
Thank you for your feedback

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Congrats on your first PR here

@MaoShizhong MaoShizhong merged commit 2611d79 into TheOdinProject:main Jun 30, 2024
3 checks passed
@CJKbarts
Copy link
Contributor Author

Thank you

@CJKbarts
Copy link
Contributor Author

Do I delete the branch then?

@MaoShizhong
Copy link
Contributor

Do I delete the branch then?

You can safely delete the branch now that it's been merged.

@CJKbarts CJKbarts deleted the descriptive_link_text branch June 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants