Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset_pipeline.md: Removed a outdated learning objective #28295

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

theSamyak
Copy link
Contributor

Removed a outdated learning objective - How to display raw HTML code in asset_pipeline.md in reference to issue #28064

Because

This PR removes an outdated learning objective from the "Ruby on Rails - The Asset Pipeline" lesson. The objective referenced displaying raw HTML code in the app, but this section was removed from the lesson content in the past. This update ensures the curriculum accurately reflects the current lesson structure.

This PR

Issue

Closes #28064

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Removed a outdated learning objective - How to display raw HTML code in asset_pipeline.md in reference to issue TheOdinProject#28064
@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Jun 28, 2024
@theSamyak theSamyak changed the title Removed a outdated learning objective in asset_pipeline.md [fixing issue #28064] asset_pipeline.md: Removed a outdated learning objective Jun 28, 2024
replaced  tildes (~~~) with backticks (```) in the codeblocks in asset_pipeline.md that were causing errors
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @theSamyak.

If you're happy to fix the rest of the linting errors, you can best do this by working with a local clone of your fork and branch since there are so many, where you can follow our local linting instructions. Two passes of the fix:lesson script should result in one h3/h4 error left that can only be fixed manually.

Let me know if you're comfortable doing this. If so, go ahead and hit the "re-request review" button as shown below to let me know when you're done with those fixes. Feel free to ask any question if you run into issues.

image

Conversely, if you're not comfortable with fixing these here, let me know and I'll be happy to merge this PR as is, since it does resolve the linked issue. The lint errors can be solved separately another time.

@theSamyak
Copy link
Contributor Author

Thanks for doing this, @theSamyak.

If you're happy to fix the rest of the linting errors, you can best do this by working with a local clone of your fork and branch since there are so many, where you can follow our local linting instructions. Two passes of the fix:lesson script should result in one h3/h4 error left that can only be fixed manually.

Let me know if you're comfortable doing this. If so, go ahead and hit the "re-request review" button as shown below to let me know when you're done with those fixes. Feel free to ask any question if you run into issues.

image

Conversely, if you're not comfortable with fixing these here, let me know and I'll be happy to merge this PR as is, since it does resolve the linked issue. The lint errors can be solved separately another time.

Hi @MaoShizhong ,

Thank you for the clear instructions. I would gladly fix the remaining linting errors. I'll follow your suggestions and re-request a review when I'm done.
You can merge this PR as it would be more efficient for me to work on a separate branch dedicated to resolving these issues.

I plan to start working on this by tomorrow or the day after. If I encounter any issues, I'll reach out for guidance. I hope you have a great day!

@MaoShizhong
Copy link
Contributor

Sure thing. I'll merge this one, then you can work on a separate PR for the remaining lint issues. In that PR, you can add Related to #28295 in the PR form to provide context for it.

@MaoShizhong MaoShizhong merged commit 78755d6 into TheOdinProject:main Jun 28, 2024
2 of 3 checks passed
@theSamyak
Copy link
Contributor Author

Sure thing. I'll merge this one, then you can work on a separate PR for the remaining lint issues. In that PR, you can add Related to #28295 in the PR form to provide context for it.

Gotcha! Thanks for merging this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Asset Pipeline: <learning overview item with no reference in lesson>
2 participants