Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are few problems with
perfect_cube.rs
:perfect_cube
is not tested (note the typo in thetest_perfect_cube
),perfect_cube
andperfect_cube_binary_search
should have the same input type,perfect_cube
does not give the correct result for64 = 4*4*4
,-8 = (-2)*(-2)*(-2)
, so why-8
is not a perfect cube here?This PR fixes above issues by removing
perfect_cube
function and reorganizes the tests.Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.added myremoved algorithmtofrom the correspondingmod.rs
file within its own folder, and in any parent folder(s).COUNTRIBUTING.md
and my code follows its guidelines.