Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup perfect_cube.rs #655

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jan 9, 2024

Description

There are few problems with perfect_cube.rs:

This PR fixes above issues by removing perfect_cube function and reorganizes the tests.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my removed algorithm to from the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb3b21d) 94.57% compared to head (647cdbf) 94.60%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   94.57%   94.60%   +0.03%     
==========================================
  Files         285      286       +1     
  Lines       22906    22924      +18     
==========================================
+ Hits        21664    21688      +24     
+ Misses       1242     1236       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review January 9, 2024 16:24
@siriak siriak merged commit 4fe660e into TheAlgorithms:master Jan 10, 2024
4 checks passed
@vil02 vil02 deleted the cleanup_perfect_cube branch January 10, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants