Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hinge Loss #648

Merged
merged 8 commits into from
Jan 15, 2024
Merged

feat: Hinge Loss #648

merged 8 commits into from
Jan 15, 2024

Conversation

mobley-trent
Copy link
Contributor

@mobley-trent mobley-trent commented Jan 6, 2024

Pull Request Template

Description

This PR is a sub task of issue #559 . It adds Hinge Loss algorithm under the Machine Learning directory.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bbc45c) 94.65% compared to head (b40fb79) 94.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   94.65%   94.66%           
=======================================
  Files         289      290    +1     
  Lines       23144    23161   +17     
=======================================
+ Hits        21908    21925   +17     
  Misses       1236     1236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mobley-trent mobley-trent marked this pull request as ready for review January 9, 2024 06:42
@siriak
Copy link
Member

siriak commented Jan 9, 2024

Please fix cargo clippy. See how it's handled in other files

@mobley-trent
Copy link
Contributor Author

Hello @siriak , it seems that I can only fix cargo clippy by adding #[warn(dead_code)] but I don't see this in the rest of the loss functions.

@siriak
Copy link
Member

siriak commented Jan 15, 2024

Please take a look at new errors. I think this may be because the name of module and function coincide, but it's just a guess. You should be able to fix this without #[warn(dead_code)]

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit d3670a2 into TheAlgorithms:master Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants