-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly evaluate GITHUB_ACTOR
#647
Properly evaluate GITHUB_ACTOR
#647
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 283 283
Lines 22801 22801
=======================================
Hits 21566 21566
Misses 1235 1235 ☔ View full report in Codecov by Sentry. |
a517d25
to
12ecf53
Compare
GITHUB_ACTOR
GITHUB_ACTOR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
About the name, let's set it to "Github Actor". Looks reasonable. Could you do that here? |
31a46a3
to
7c14b96
Compare
Description
git log
contains records like:This PR properly evaluates the
GITHUB_ACTOR
variable in the respective workflow. When this will be merged, I will create similar PR in other repos.Something to consider
Since
user.email
is generated usingGITHUB_ACTOR
, should alsouser.name
be set toGITHUB_ACTOR
?Type of change
Please delete options that are not relevant.
Checklist:
COUNTRIBUTING.md
and my code follows its guidelines.