Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LeetCode directory writer #1281

Merged
merged 4 commits into from
Jul 19, 2023
Merged

fix: LeetCode directory writer #1281

merged 4 commits into from
Jul 19, 2023

Conversation

Panquesito7
Copy link
Member

Description of Change

  • Fix LeetCode directory writer.
    • The || true code is needed in case there are no changes to make or the PR already exists so that the script doesn't fail and exits completely.

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the bugfix Correction to existing algorithms label Jun 27, 2023
alexpantyukhin
alexpantyukhin previously approved these changes Jul 3, 2023
View reviewed changes
@github-actions github-actions bot added the approved Approved; waiting for merge label Jul 3, 2023
@Panquesito7
Copy link
Member Author

Will be merging for now. In case there are any objections, feel free to create another PR to fix those. 🙂

@Panquesito7 Panquesito7 merged commit 77522fd into master Jul 19, 2023
5 checks passed
@Panquesito7 Panquesito7 deleted the leetcode_writer_fix branch July 19, 2023 02:41
@github-actions github-actions bot restored the leetcode_writer_fix branch July 19, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhavgaba madhavgaba madhavgaba approved these changes

@alexpantyukhin alexpantyukhin alexpantyukhin left review comments

@tjgurwara99 tjgurwara99 Awaiting requested review from tjgurwara99 tjgurwara99 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge bugfix Correction to existing algorithms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panquesito7 @alexpantyukhin @madhavgaba