-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added hangman game #967 #1248
Conversation
feat: added hangman game TheAlgorithms#967
feat: added hangman game TheAlgorithms#967
@CascadingCascade Thank you for the code review! It was really helpful. I'll work on improving the initialisation process. |
Glad to be of help then! I should be online for a few more hours, just ask away if you need help and I'll do my best:) |
@Panquesito7 Thank you for the review! I'll definitely work on the |
Updated so that game instance was held as struct - can include current guess in game_instance too if preferred.
Added struct implementation - would it be better to change arguments of functions, such as in_word and new_guess, to pointers? |
@Panquesito7 fixed fgets 100. |
@CascadingCascade Thank you again for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 🙂
I have to say this is a pretty fun game! 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thank you. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But as a matter of personal preference, I like to ponder about how things could have been, and left some more food for thought in the comments.
Description of Change
C implementation of the traditional hangman game (with duck graphic).
References
Issue #967
Checklist
Notes:
Test cases may need to be improved.