Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add McNaughton–Yamada–Thompson algorithm #1241

Merged
merged 18 commits into from
Apr 12, 2023

Conversation

CascadingCascade
Copy link
Collaborator

Description of Change

Added a NFA regex matcher based on the McNaughton–Yamada–Thompson algorithm

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
It's been awhile since my last PR, and this is what I've cooked up.:smile: I tried my best, but a program this large is bound to have more bugs than what I managed to found, thanks in advance for sifting through ~700 lines of code.

@Panquesito7 Panquesito7 added the enhancement New feature or request label Mar 31, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks! 🚀

Copy link
Member

@alexpantyukhin alexpantyukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

@Panquesito7 Panquesito7 merged commit e1fcdd2 into TheAlgorithms:master Apr 12, 2023
@CascadingCascade CascadingCascade deleted the regex branch April 12, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants