Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 425 - Migrate to DotNet 8 - File-scoped namespaces: Algorithms,… #430

Conversation

gmottajr
Copy link
Contributor

Issue 425 - Migrate to DotNet 8 - File-scoped namespaces: Algorithms, Knapsack,
LinearAlgebra, ModularArithmetic, Numeric

Please let me know whether or not it would be necessary to create new unit tests for this change.

Motivation and Context
Github issue #425: Proposed to update to File-scoped namespaces. It was requested to perform the changes in a few PRs to make them smaller and easier to review. This is the one only meant to update .NET version.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

… Knapsack, LinearAlgebra, ModularArithmetic, Numeric
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (231167f) 94.50% compared to head (fc30ead) 94.50%.

Files Patch % Lines
Algorithms/Numeric/GaussJordanElimination.cs 94.82% 1 Missing and 2 partials ⚠️
...ithms/ModularArithmetic/ChineseRemainderTheorem.cs 97.22% 0 Missing and 2 partials ⚠️
...orithms/LinearAlgebra/Eigenvalue/PowerIteration.cs 94.44% 1 Missing ⚠️
Algorithms/Numeric/AmicableNumbersChecker.cs 87.50% 0 Missing and 1 partial ⚠️
Algorithms/Numeric/Decomposition/ThinSVD.cs 98.18% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         234      234           
  Lines        9843     9843           
  Branches     1455     1455           
=======================================
  Hits         9302     9302           
  Misses        381      381           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 3d92c39 into TheAlgorithms:master Dec 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants