Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize String Algorithms #418

Merged
merged 6 commits into from
Oct 14, 2023

Conversation

Kalkwst
Copy link
Contributor

@Kalkwst Kalkwst commented Oct 12, 2023

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@Kalkwst Kalkwst requested a review from siriak as a code owner October 12, 2023 14:54
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (102f8c6) 96.03% compared to head (47e1e83) 96.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         231      231           
  Lines        9665     9665           
=======================================
  Hits         9282     9282           
  Misses        383      383           
Files Coverage Δ
Algorithms/Strings/PatternMatching/BoyerMoore.cs 100.00% <ø> (ø)
...trings/PatternMatching/KnuthMorrisPrattSearcher.cs 100.00% <ø> (ø)
...ithms/Strings/PatternMatching/NaiveStringSearch.cs 100.00% <ø> (ø)
Algorithms/Strings/PatternMatching/RabinKarp.cs 100.00% <ø> (ø)
...s/Strings/PatternMatching/ZblockSubstringSearch.cs 100.00% <ø> (ø)
Algorithms/Strings/Similarity/HammingDistance.cs 100.00% <ø> (ø)
Algorithms/Strings/Similarity/JaroSimilarity.cs 100.00% <ø> (ø)
...gorithms/Strings/Similarity/JaroWinklerDistance.cs 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only have 1 comment

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 8dfab48 into TheAlgorithms:master Oct 14, 2023
4 checks passed
@Kalkwst Kalkwst deleted the feature/OrganizeStringAlgorithms branch July 25, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants