Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: median_search bug #850

Closed
wants to merge 2 commits into from
Closed

Conversation

Kia-G
Copy link

@Kia-G Kia-G commented Jun 15, 2020

Description of Change: Fixed sorting into subsets in main() and branching conditions in comp(). Changed rand_r() to rand(). Fixed typos and whitespace errors.

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: The list will not print in ascending order because it is not necessary to sort the entire list.

#include<deque>
#include<stack>
#include<vector>
#include<algorithm>
#include<iterator>
using namespace std;
#include<cstdlib>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include<cstdlib>
#include <cstdlib>

@kvedala
Copy link
Collaborator

kvedala commented Jun 19, 2020

@Kia-G There seem to be conflicts in the files. Some of your suggested changes were incorporated as part of #805 that was recently merged.

please rebase your commits on the master branch. When you do, you will get a message that there is a conflicting file that you'd have to resolve and commit.
Or, if you prefer, you can fork the new master, make the changes and create a new pull-request.

Thank you

@kvedala kvedala added bugfix Correction to existing algorithms merge conflicts labels Jun 22, 2020
@kvedala kvedala linked an issue Jun 28, 2020 that may be closed by this pull request
@kvedala kvedala added the stale Author has not responded to the comments for over 2 weeks label Jul 21, 2020
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

@github-actions github-actions bot closed this Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Correction to existing algorithms merge conflicts stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect results
3 participants