test: Add self-test cases in the math/power_of_two.cpp file
#1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added assert & a clean code.
Panquesito7
requested changes
Oct 10, 2021
math/power_of_two.cpp
Outdated
Comment on lines
24
to
25
| //Added self implementation Cases Contribution | ||
|
|
There was a problem hiding this comment.
Suggested change
| //Added self implementation Cases Contribution |
math/power_of_two.cpp
Outdated
Comment on lines
27
to
28
| #include <cassert> ///for assert | ||
|
|
There was a problem hiding this comment.
Suggested change
| #include <cassert> ///for assert | |
| #include <cassert> /// for assert |
math/power_of_two.cpp
Outdated
Comment on lines
45
to
46
| * returns 1 if n is power of 2 | ||
| * returns 0 if n is not a power of 2 |
There was a problem hiding this comment.
Suggested change
| * returns 1 if n is power of 2 | |
| * returns 0 if n is not a power of 2 | |
| * prints the result, as "Yes, the number n is a power of 2" or | |
| * "No, the number is not a power of 2" without quotes | |
| * @returns 1 if `n` IS the power of 2 | |
| * @returns 0 if n is NOT a power of 2 |
math/power_of_two.cpp
Outdated
Comment on lines
51
to
54
|
|
||
| if(result == 0) return 1 ; //yes it is | ||
| else return 0; // no it is not | ||
|
|
There was a problem hiding this comment.
Suggested change
| if(result == 0) return 1 ; //yes it is | |
| else return 0; // no it is not | |
| if (result == 0) { | |
| std::cout << "Yes, the number " << n << " is a power of 2"; | |
| } else { | |
| std::cout << "No, the number " << n << " is not a power of 2"; | |
| } |
math/power_of_two.cpp
Outdated
| assert(math::power_of_two(232) == 0); | ||
| std::cout << "Passed\n"; | ||
|
|
||
| std::cout << "All test cases passed! \n"; |
There was a problem hiding this comment.
Suggested change
| std::cout << "All test cases passed! \n"; | |
| std::cout << "All test cases passed!\n"; |
math/power_of_two.cpp
Outdated
|
|
||
| test(); //run self-test implementations | ||
|
|
||
| //UN - COMMENT BELOW LINE TO TAKE USER INPUTS |
There was a problem hiding this comment.
Suggested change
| //UN - COMMENT BELOW LINE TO TAKE USER INPUTS | |
| // uncomment the line below to take user inputs |
math/power_of_two.cpp
Outdated
| /** | ||
| * @brief Main function | ||
| * @returns 0 on exit | ||
| */ | ||
|
|
math/power_of_two.cpp
Outdated
| * @brief take user input | ||
| * @returns void | ||
| */ | ||
|
|
math/power_of_two.cpp
Outdated
| } | ||
|
|
||
| /** | ||
| * @brief take user input |
There was a problem hiding this comment.
Suggested change
| * @brief take user input | |
| * @brief Take user input in the test cases (optional; currently commented) |
Panquesito7
changed the title
Panquesito7
changed the title
math/power_of_two.cpp file
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Panquesito7
removed
the
stale
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Panquesito7
removed
the
stale
Panquesito7
approved these changes
Feb 10, 2022
Panquesito7
requested review from
aminoxix,
ayaankhan98,
CarlosZoft and
mishraabhinn
mishraabhinn
approved these changes
Feb 10, 2022
CarlosZoft
reviewed
Feb 10, 2022
| if (result == 0) { | ||
| std::cout << "Yes, the number " << n << " is a power of 2"; | ||
| return 1; | ||
| } else { |
There was a problem hiding this comment.
'else' is redundant in this case
There was a problem hiding this comment.
Hey there! Want to make a PR to fix this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
<!
//* Added Self Implementation cases
//* Necessary changes for user inputs
//* Changed necessary comments
Thank you for your Pull Request. Please provide a description above and review
the requirements below.
Contributors guide: https://github.com/TheAlgorithms/C-Plus-Plus/CONTRIBUTING.md
-->
Checklist
Notes: