Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Travelling Salesman Problem(Naive Approach) #1590

Merged
merged 27 commits into from
Sep 12, 2021

Conversation

Mayank17M
Copy link
Member

@Mayank17M Mayank17M commented Sep 4, 2021

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thanks for your contribution. We request you to follow contribution guidelines

@Mayank17M
Copy link
Member Author

Made some changes.
@ayaankhan98 Please check if it is appropriate now. Thanks!

Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow contribution guidelines

Thanks.

@Panquesito7 Panquesito7 changed the title Add Travelling Salesman Problem(Naive Approach) feat: Add Travelling Salesman Problem(Naive Approach) Sep 5, 2021
@Panquesito7 Panquesito7 added automated tests are failing Do not merge until tests pass enhancement New feature or request Proper Documentation Required requested to write the documentation properly requested changes changes have been requested labels Sep 5, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, @ayaankhan98! 😄
@Mayank17M, in case you are confused or don't know what to do, you can check the typical structure of a program. I hope that helps. Let us know if you need any more help. 🙂

@Mayank17M
Copy link
Member Author

Thankyou @Panquesito7 , I'll make the necessary changes.
Thanks! :)

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😄👍

graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
@Mayank17M
Copy link
Member Author

I think all the requested changes have been covered.
Please review @Panquesito7

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Great work! 😄👍
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Mayank17M/C-Plus-Plus/actions

graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 removed automated tests are failing Do not merge until tests pass Proper Documentation Required requested to write the documentation properly labels Sep 10, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all that needs to be addressed, and your PR will be merged! 🎉

graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
graph/travelling_salesman_problem.cpp Outdated Show resolved Hide resolved
@Mayank17M
Copy link
Member Author

Addressed all the requested changes. Please review. Thanks!

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @Mayank17M! It's been great for your first contribution here! We hope you keep contributing! 😄👍🎉

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Sep 12, 2021
@aminoxix
Copy link
Member

@Panquesito7: Here's the output, goes in:

image

Is it shows correct?

@Panquesito7
Copy link
Member

@Panquesito7: Here's the output, goes in:

image

Is it shows correct?

That looks correct for me. @Mayank17M, does that look correct?

@Mayank17M
Copy link
Member Author

Yep, that's correct :)

Copy link
Member

@aminoxix aminoxix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mayank17M: LGTM! 🥳

@Panquesito7
Copy link
Member

Thanks for reviewing @Amino19! 😄

@Panquesito7 Panquesito7 merged commit 040237d into TheAlgorithms:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants