tests: Add test in `cycle_sort.cpp` #1520

Swastyy · 2021-06-29T18:44:11Z

Description of Change

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:

Swastyy · 2021-06-29T19:01:50Z

@Panquesito7 Sorry for taking your time in the same kind of file edit/PR again. Its because I contributed for the first time and just to get updates from the master repo to forked repo I forked it again. But I assure you that it won't take long for this PR since you already approved it and I have used the same code as before basically re-created the pull request.

Panquesito7

That's the only thing missing! After that, I'll approve this PR. 🙂

Panquesito7 · 2021-07-02T21:19:49Z

sorting/cycle_sort.cpp

- * @brief Implementation of [Cycle
- * sort](https://en.wikipedia.org/wiki/Cycle_sort) algorithm
- *
+ * @brief Implementation of [Cycle sort](https://en.wikipedia.org/wiki/Cycle_sort) algorithm


I'd like you to put this back as it was (same in lines 5 and 21).

They are currently 1-line descriptions.

mishraabhinn

Reference
Do this contribution is some different. We already have a cycle_sort. @Panquesito7

Swastyy · 2021-07-05T18:59:38Z

Reference
Do this contribution is some different. We already have a cycle_sort. @Panquesito7

https://github.com/TheAlgorithms/C-Plus-Plus/projects/6#card-63413841

sorting/cycle_sort.cpp

Co-authored-by: Abhinn Mishra <[email protected]>

Swastyy · 2021-07-06T03:53:18Z

Hey, after committing the above suggestions I got mail as Run failed: CodeQL... but here everything is working fine. Isn't it?

mishraabhinn · 2021-07-06T13:03:59Z

Hey, after committing the above suggestions I got mail as Run failed: CodeQL... but here everything is working fine. Isn't it?

Is it working now?

Swastyy · 2021-07-06T14:42:47Z

Hey, after committing the above suggestions I got mail as Run failed: CodeQL... but here everything is working fine. Isn't it?

Is it working now?

Yea, I think so. 😕
Like git bot has pushed it so there aren't any issues.

mishraabhinn · 2021-07-06T14:46:00Z

Hey, after committing the above suggestions I got mail as Run failed: CodeQL... but here everything is working fine. Isn't it?

Is it working now?

Yea, I think so. 😕
Like git bot has pushed it so there aren't any issues.

If you got mail there is issue. Something went wrong. Go to workflow and see the error.

mishraabhinn · 2021-07-06T14:56:49Z

sorting/cycle_sort.cpp

@@ -98,9 +98,9 @@ static void test() {
 std::cout << "passed" << std::endl;

 // [4.3, -6.5, -7.4, 0, 2.7, 1.8] return [-7.4, -6.5, 0, 1.8, 2.7, 4.3]
- std::vector<double> array2 = {4.3, -6.5, -7.4, 0, 2.7, 1.8};
+ std::vector<int> array2 = {4.3, -6.5, -7.4, 0, 2.7, 1.8};


Sorry 1 sec

20 minutes and no mail yet 😕

Swastyy · 2021-07-08T09:52:36Z

@mishraabhinn errors resolved 😃

Panquesito7

Almost there! 😄

sorting/cycle_sort.cpp

Co-authored-by: David Leal <[email protected]>

Panquesito7

Looks good. Thank you for your contribution! 👍 🎉

ayaankhan98

Earlier approval by mistake.

test.cpp: In instantiation of ‘std::vector<T> sorting::cycle_sort::cycleSort(const std::vector<T>&) [with T = unsigned int]’:
test.cpp:96:64:   required from here
test.cpp:53:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   53 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:59:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   59 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:65:20: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   65 |         while (pos != cycle_start) {
      |                ~~~~^~~~~~~~~~~~~~
test.cpp: In instantiation of ‘std::vector<T> sorting::cycle_sort::cycleSort(const std::vector<T>&) [with T = double]’:
test.cpp:103:62:   required from here
test.cpp:53:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   53 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:59:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   59 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:65:20: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   65 |         while (pos != cycle_start) {
      |                ~~~~^~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

shell returned 1

Swastyy · 2021-07-12T09:49:59Z

Earlier approval by mistake.

test.cpp: In instantiation of ‘std::vector<T> sorting::cycle_sort::cycleSort(const std::vector<T>&) [with T = unsigned int]’:
test.cpp:96:64:   required from here
test.cpp:53:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   53 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:59:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   59 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:65:20: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   65 |         while (pos != cycle_start) {
      |                ~~~~^~~~~~~~~~~~~~
test.cpp: In instantiation of ‘std::vector<T> sorting::cycle_sort::cycleSort(const std::vector<T>&) [with T = double]’:
test.cpp:103:62:   required from here
test.cpp:53:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   53 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:59:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   59 |         if (pos == cycle_start) {
      |             ~~~~^~~~~~~~~~~~~~
test.cpp:65:20: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   65 |         while (pos != cycle_start) {
      |                ~~~~^~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

shell returned 1

Sorry for this have changed the data type of iterators.

Panquesito7

All fine for me. I'll merge this now. If anybody finds any objections, please make another PR to fix them. Thanks! 😄

Update cycle_sort.cpp

38ce79e

Swastyy closed this Jun 29, 2021

Swastyy reopened this Jun 29, 2021

Panquesito7 added the enhancement New feature or request label Jul 2, 2021

Panquesito7 reviewed Jul 2, 2021

View reviewed changes

mishraabhinn reviewed Jul 5, 2021

View reviewed changes

mishraabhinn requested changes Jul 6, 2021

View reviewed changes

sorting/cycle_sort.cpp Outdated Show resolved Hide resolved

sorting/cycle_sort.cpp Outdated Show resolved Hide resolved

sorting/cycle_sort.cpp Outdated Show resolved Hide resolved

sorting/cycle_sort.cpp Outdated Show resolved Hide resolved

Swastyy and others added 3 commits July 6, 2021 09:13

Update sorting/cycle_sort.cpp

33fb608

Co-authored-by: Abhinn Mishra <[email protected]>

Update sorting/cycle_sort.cpp

2601c62

Co-authored-by: Abhinn Mishra <[email protected]>

clang-format and clang-tidy fixes for 2601c62

d9bb81c

Update cycle_sort.cpp

82107ba

mishraabhinn reviewed Jul 6, 2021

View reviewed changes

Swastyy and others added 3 commits July 6, 2021 20:28

Update cycle_sort.cpp

7726eba

Update cycle_sort.cpp

39cf3f3

clang-format and clang-tidy fixes for 39cf3f3

646dfc0

Swastyy requested review from mishraabhinn and Panquesito7 July 8, 2021 09:52

Panquesito7 changed the title ~~Update cycle_sort.cpp~~ tests: Add test in cycle_sort.cpp Jul 9, 2021

Panquesito7 requested changes Jul 9, 2021

View reviewed changes

sorting/cycle_sort.cpp Outdated Show resolved Hide resolved

sorting/cycle_sort.cpp Outdated Show resolved Hide resolved

Swastyy and others added 2 commits July 10, 2021 09:32

Update sorting/cycle_sort.cpp

9509051

Co-authored-by: David Leal <[email protected]>

Update cycle_sort.cpp

92334d8

Swastyy requested a review from Panquesito7 July 10, 2021 07:28

Panquesito7 previously approved these changes Jul 11, 2021

View reviewed changes

Panquesito7 added the approved Approved; waiting for merge label Jul 11, 2021

Panquesito7 requested a review from ayaankhan98 July 11, 2021 19:08

suprithars111 previously approved these changes Jul 11, 2021

View reviewed changes

ayaankhan98 approved these changes Jul 12, 2021

View reviewed changes

ayaankhan98 requested changes Jul 12, 2021

View reviewed changes

Update cycle_sort.cpp

6a57901

Swastyy dismissed stale reviews from suprithars111 and Panquesito7 via 6a57901 July 12, 2021 09:46

Swastyy requested review from ayaankhan98 and Panquesito7 July 12, 2021 09:59

Panquesito7 approved these changes Jul 13, 2021

View reviewed changes

Panquesito7 merged commit 82290e7 into TheAlgorithms:master Jul 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: Add test in `cycle_sort.cpp` #1520

tests: Add test in `cycle_sort.cpp` #1520

Swastyy commented Jun 29, 2021 •

edited

Loading

Swastyy commented Jun 29, 2021

Panquesito7 left a comment

Panquesito7 Jul 2, 2021

Swastyy Jul 3, 2021

mishraabhinn left a comment

Swastyy commented Jul 5, 2021

Swastyy commented Jul 6, 2021

mishraabhinn commented Jul 6, 2021

Swastyy commented Jul 6, 2021

mishraabhinn commented Jul 6, 2021

mishraabhinn Jul 6, 2021

Swastyy Jul 6, 2021

Swastyy Jul 6, 2021

Swastyy commented Jul 8, 2021

Panquesito7 left a comment

Panquesito7 left a comment

ayaankhan98 left a comment •

edited

Loading

Swastyy commented Jul 12, 2021

Panquesito7 left a comment

tests: Add test in cycle_sort.cpp #1520

tests: Add test in cycle_sort.cpp #1520

Conversation

Swastyy commented Jun 29, 2021 • edited Loading

Description of Change

Checklist

Swastyy commented Jun 29, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

Panquesito7 Jul 2, 2021

Choose a reason for hiding this comment

Swastyy Jul 3, 2021

Choose a reason for hiding this comment

mishraabhinn left a comment

Choose a reason for hiding this comment

Swastyy commented Jul 5, 2021

Swastyy commented Jul 6, 2021

mishraabhinn commented Jul 6, 2021

Swastyy commented Jul 6, 2021

mishraabhinn commented Jul 6, 2021

mishraabhinn Jul 6, 2021

Choose a reason for hiding this comment

Swastyy Jul 6, 2021

Choose a reason for hiding this comment

Swastyy Jul 6, 2021

Choose a reason for hiding this comment

Swastyy commented Jul 8, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

ayaankhan98 left a comment • edited Loading

Choose a reason for hiding this comment

Swastyy commented Jul 12, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

tests: Add test in `cycle_sort.cpp` #1520

tests: Add test in `cycle_sort.cpp` #1520

Swastyy commented Jun 29, 2021 •

edited

Loading

ayaankhan98 left a comment •

edited

Loading