Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added persistent segment tree with lazy propagation #1445

Merged
merged 22 commits into from
Feb 8, 2021
Merged

feat: Added persistent segment tree with lazy propagation #1445

merged 22 commits into from
Feb 8, 2021

Conversation

MSedra
Copy link
Contributor

@MSedra MSedra commented Jan 27, 2021 •
edited by gitpod-io bot
Loading

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Panquesito7
Panquesito7 requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is not up to the repository standards.
Please read them carefully and follow them.

@Panquesito7 Panquesito7 added automated tests are failing Do not merge until tests pass enhancement New feature or request requested changes changes have been requested labels Jan 27, 2021
@MSedra
Copy link
Contributor Author

MSedra commented Jan 27, 2021

Code is not up to the repository standards.
Please read them carefully and follow them.

I have read the standards and tried to follow them as much as i could. Can you please elaborate which standard/s am i not following? Is using normal pointers not allowed?

Panquesito7
Panquesito7 reviewed Jan 27, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start: first, we need to fix clang-tidy warnings. 🙂

@MSedra
Copy link
Contributor Author

MSedra commented Jan 27, 2021

Let's start: first, we need to fix clang-tidy warnings. 🙂

Why do i get warnings when using normal pointers?

@Panquesito7 Panquesito7 removed the automated tests are failing Do not merge until tests pass label Jan 27, 2021
@MSedra
Copy link
Contributor Author

MSedra commented Jan 27, 2021

Let's start: first, we need to fix clang-tidy warnings. 🙂

Done. What's next?

@Panquesito7 Panquesito7 changed the title Added persistent segment tree with lazy propagation feat: Added persistent segment tree with lazy propagation Jan 31, 2021
Panquesito7
Panquesito7 requested changes Jan 31, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/MSedra/C-Plus-Plus/actions

Panquesito7
Panquesito7 requested changes Jan 31, 2021
View reviewed changes
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work! Well done.
Would you please consider editing the filename to make it shorter?
Also consider using uint64_t (for non-negative values), int64_t (for negative values) or their appropriate size in all the code.

Thank you. 🙂

range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
range_queries/persistent_segment_tree_with_lazy_propagation.cpp Outdated Show resolved Hide resolved
@MSedra
Copy link
Contributor Author

MSedra commented Feb 7, 2021

@ayaankhan98 can you please review the last changes?

Panquesito7
Panquesito7 approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks amazing! LGTM; thanks for your contribution! 👍 🎉

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Feb 8, 2021
@Panquesito7 Panquesito7 merged commit b12dad0 into TheAlgorithms:master Feb 8, 2021
@MSedra
Copy link
Contributor Author

MSedra commented Feb 9, 2021

Great work, looks amazing! LGTM; thanks for your contribution! 👍 🎉

Thank you so much for your help

ayaankhan98 pushed a commit to ayaankhan98/C-Plus-Plus that referenced this pull request Feb 11, 2021
@MSedra @Panquesito7 @ayaankhan98
feat: Added persistent segment tree with lazy propagation (TheAlgorit…
59be3fa 
…hms#1445)

* Added persistent segment tree with lazy propagation

* Updated

* Updated

* Updated

* Updated

* Updated

* Updated

* Added a documentation

* Updated

* updating DIRECTORY.md

* clang-format and clang-tidy fixes for 4b6566d

* Updated

* clang-format and clang-tidy fixes for 6197ba4

* Update persistent_segment_tree_with_lazy_propagation.cpp

* Updated

* Delete persistent_segment_tree_with_lazy_propagation.cpp

* Updated

* updating DIRECTORY.md

* clang-format and clang-tidy fixes for 81621d8

* Update persistent_seg_tree_lazy_prop.cpp

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSedra @ayaankhan98 @Panquesito7