Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Saddleback search #1432

Merged
merged 10 commits into from
Dec 2, 2020
Merged

feat: Add Saddleback search #1432

merged 10 commits into from
Dec 2, 2020

Conversation

HashirGJ8842
Copy link
Contributor

@HashirGJ8842 HashirGJ8842 commented Nov 29, 2020 •
edited by gitpod-io bot
Loading

Description of Change

Added Saddleback search algorithm for 2D array.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@lgtm-com

This comment has been minimized.

Sign in to view
Panquesito7
Panquesito7 requested changes Nov 29, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good code.
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/HashirGJ8842/C-Plus-Plus/actions

search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added enhancement New feature or request requested changes changes required labels Nov 29, 2020
@Panquesito7
Copy link
Member

This pull request introduces 1 alert when merging 34f8c4a into de99092 - view on LGTM.com

new alerts:

  • 1 for Unsigned comparison to zero

Please fix the warnings above.

Panquesito7
Panquesito7 requested changes Nov 30, 2020
View reviewed changes
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
search/saddleback_search.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, I like how you've made the code. 🎉
Code and documentation looks good and very refined. 😄 👍

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes required labels Dec 1, 2020
@HashirGJ8842
Copy link
Contributor Author

Thanks :)

ayaankhan98
ayaankhan98 reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me!

ayaankhan98
ayaankhan98 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayaankhan98 ayaankhan98 merged commit 60c607b into TheAlgorithms:master Dec 2, 2020
ayaankhan98 pushed a commit to ayaankhan98/C-Plus-Plus that referenced this pull request Feb 11, 2021
@HashirGJ8842 @ayaankhan98
feat: Add Saddleback search (TheAlgorithms#1432)
40eaea4 
* feat: add saddleback search algorithm

* docs: add comments and explaination for saddleback algorithm

* test: add test for saddleback algorithm

* refactor: use size_t instead of int

* refactor: made suggested changes

* updating DIRECTORY.md

* refactor: made suggested changes

* refactor: made suggested changes

* refactor: made suggested changes

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HashirGJ8842 @Panquesito7 @ayaankhan98