feat: add 2-3-4-tree implment #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
requested changes
Oct 21, 2020
There was a problem hiding this comment.
Please fix clang-tidy warnings.
Code is not up to the repository standards.
Please read them carefully and follow them.
|
hi Panquesito7, I have fix most of the warnings. But replacing fprintf() with std::cout and manging node with smart pointer is a little pain. Any suggestions? |
You can run GitPod on the web for more detailed errors. 🙂 |
Panquesito7
reviewed
Oct 25, 2020
Panquesito7
requested changes
Oct 26, 2020
Panquesito7
requested changes
Oct 27, 2020
Add namespaces Co-authored-by: David Leal <[email protected]>
Panquesito7
approved these changes
Oct 27, 2020
Thank you for your credit and your help.😄 |
|
hi @ayaankhan98 , can you please review the code? |
ayaankhan98
approved these changes
Dec 1, 2020
thank you:) |
ayaankhan98
pushed a commit
to ayaankhan98/C-Plus-Plus
that referenced
this pull request
Feb 11, 2021
* feat: add 2-3-4 tree implment * updating DIRECTORY.md * docs: fix format issue of tab&space * fix: fix code format issues * fix: convert printf() to std::cout * fix: fix some clang-tidy warnings * fix: fix clang-tidy warnings of memory owning * fix: remove use of std::make_unique which is not support by c++11 * docs: improve documents * fix: replace fprint with ofstream, and improve docs * docs: improve docs for including header file * docs: improve file doces * fix: convert item type to int64_t, convert node item count type to int8_t * refactor: Apply suggestions from code review Add namespaces Co-authored-by: David Leal <[email protected]> * docs: remove obsolete comments Co-authored-by: liuhuan <[email protected]> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: David Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
feat: add 2-3-4-tree implment
Checklist
Notes: