Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]: dynamic_programming/cut_rod.cpp does not compile #1085

Merged
merged 30 commits into from
Sep 30, 2020
Merged

[fix]: dynamic_programming/cut_rod.cpp does not compile #1085

merged 30 commits into from
Sep 30, 2020

Conversation

Pardeep009
Copy link
Contributor

@Pardeep009 Pardeep009 commented Sep 23, 2020 •
edited by gitpod-io bot
Loading

Description of Change

included climits library in code to remove compilation error.

Checklist

  • Added description of change
  • PR title follows semantic commit guidelines
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Pardeep009 Pardeep009 mentioned this pull request Sep 23, 2020
Closed
@Pardeep009 Pardeep009 changed the title [fix]: getting compilation error in cut_rod.cpp code [fix]: dynamic_programming/cut_rod.cpp does not compile Sep 23, 2020
Panquesito7
Panquesito7 requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix clang-tidy warnings.

@Panquesito7 Panquesito7 added automated tests are failing Do not merge until tests pass Improvement improvement in previously written codes labels Sep 23, 2020
@kvedala kvedala linked an issue Sep 23, 2020 that may be closed by this pull request
[bug]: dynamic_programming/cut_rod.cpp does not compile #1086
Closed
@Panquesito7 Panquesito7 added requested changes changes required and removed automated tests are failing Do not merge until tests pass labels Sep 24, 2020
@Pardeep009
Copy link
Contributor Author

@Panquesito7 can you please specify me, which changes do you want in this code?
any example?

Panquesito7
Panquesito7 requested changes Sep 24, 2020
View reviewed changes
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Show resolved Hide resolved
@Pardeep009
Copy link
Contributor Author

Thank you so much for this brief explanation. I will correct them in the next commit.

Panquesito7
Panquesito7 reviewed Sep 25, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete dynamic_programming/kadane2.cpp?

Panquesito7
Panquesito7 reviewed Sep 25, 2020
View reviewed changes
dynamic_programming/kadane2.cpp Outdated Show resolved Hide resolved
dynamic_programming/kadane2.cpp Show resolved Hide resolved
@Pardeep009
Copy link
Contributor Author

Why delete dynamic_programming/kadane2.cpp?

By mistake, I have deleted it. Now it is added back.

Panquesito7
Panquesito7 requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, code looks much more refined now. 👍
Just some missing tweaks in the code needed.

dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 reviewed Sep 25, 2020
View reviewed changes
dynamic_programming/cut_rod.cpp Outdated Show resolved Hide resolved
dynamic_programming/cut_rod.cpp Show resolved Hide resolved
Panquesito7
Panquesito7 reviewed Sep 25, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Pardeep009/C-Plus-Plus/actions.

@Pardeep009
Copy link
Contributor Author

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Pardeep009/C-Plus-Plus/actions.

enabled

@Panquesito7
Copy link
Member

Panquesito7 commented Sep 25, 2020 •
edited
Loading

Please make a small commit to trigger the GitHub Actions. For example, remove line 19.
If GitHub Actions is enabled, we'll see a commit by GitHub Actions updating the modified file. 🙂

Panquesito7
Panquesito7 approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excellent work. 👍 😄

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes required labels Sep 25, 2020
kvedala
kvedala approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@kvedala kvedala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Panquesito7 Panquesito7 merged commit b09b3da into TheAlgorithms:master Sep 30, 2020
@Pardeep009
Copy link
Contributor Author

Pardeep009 commented Sep 30, 2020 •
edited
Loading

@Panquesito7 @kvedala I would like to update codes and add documentation in the remaining codes of the dynamic programming section, should i go for that?

@Panquesito7
Copy link
Member

Sounds great, please make one PR per file.
Thank you for your interest in contributing! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvedala kvedala kvedala approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
approved Approved; waiting for merge Improvement improvement in previously written codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: dynamic_programming/cut_rod.cpp does not compile
4 participants
@Pardeep009 @Panquesito7 @kvedala @anishmo99