Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/docs]: Code improvements in Fibbonacci algorithm. Code is documented. #1067

Merged
merged 4 commits into from
Aug 31, 2020

Conversation

sudonims
Copy link
Contributor

@sudonims sudonims commented Aug 30, 2020

Description of Change

Checklist

  • Added description of change
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@kvedala
Copy link
Collaborator

kvedala commented Aug 30, 2020

Thank you @sudonims
But this code seems like a duplicate of two other files in the math folder: math/fibonacci.cpp and math/fibonacci_fast.cpp
You may contribute by deleting this additional file by updating this same pull-request without creating a new one.

@sudonims
Copy link
Contributor Author

Thank you @sudonims
But this code seems like a duplicate of two other files in the math folder: math/fibonacci.cpp and math/fibonacci_fast.cpp
You may contribute by deleting this additional file by updating this same pull-request without creating a new one.

Ohh...didn't see that. Deleted the file.

Copy link
Collaborator

@kvedala kvedala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Panquesito7 Panquesito7 added approved Approved; waiting for merge Improvement improvement in previously written codes labels Aug 31, 2020
@Panquesito7 Panquesito7 merged commit 0fcdbf2 into TheAlgorithms:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge Improvement improvement in previously written codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants