Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] update openmp version & doxygen path fix #1021

Merged
merged 2 commits into from
Aug 13, 2020
Merged

[enhancement] update openmp version & doxygen path fix #1021

merged 2 commits into from
Aug 13, 2020

Conversation

kvedala
Copy link
Collaborator

@kvedala kvedala commented Aug 13, 2020 •
edited by gitpod-io bot
Loading

Description of Change

  1. updated OpenMP minimum required version to 3.0. This is to enable signed and unsigned integers in the for-loop variables.
  2. exclude "build" directory from Doxygen's search path

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@kvedala
exclude 'build' directory from doxygen
f969ebd
@kvedala
bump openmp version to 3.0
ec99853 
OpenMP >= v3.0 supports signed and unsigned for loop variables
@kvedala kvedala changed the title [enhancement] Cmake update [enhancement] update openmp version Aug 13, 2020
@kvedala kvedala changed the title [enhancement] update openmp version [enhancement] update openmp version & doxygen path fix Aug 13, 2020
@Panquesito7 Panquesito7 added the enhancement New feature or request label Aug 13, 2020
Panquesito7
Panquesito7 approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Aug 13, 2020
@kvedala kvedala merged commit 6794515 into TheAlgorithms:master Aug 13, 2020
@kvedala kvedala deleted the cmake_update branch August 13, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvedala @Panquesito7