Split up table view thrash tests #1228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lol good catch by that bot 👍 |
|
🚫 CI failed with log |
|
Fixed the source header 👍 |
|
ping @maicki How does this look now? |
|
Pushed a commit to reenable those table view thrash tests |
Generated by 🚫 Danger |
|
Closing this in favor of a new PR |
|
New PR #1246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled and split the table view thrash test into a test file and a utility. This is part of an effort to write thrash tests for the collection view as well in order to try and reproduce crazy elusive texture/UIKit sync issues