Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database secrets engine config #133

Merged
merged 23 commits into from
Jun 18, 2019
Merged

database secrets engine config #133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3b31b19
include but disable db tests
drewmullen May 31, 2019
7261209
include idemp db config module
drewmullen May 31, 2019
e6c3914
init module
drewmullen May 31, 2019
d5b3d4d
include but disable tests
drewmullen May 31, 2019
851ea04
enable tests
drewmullen Jun 3, 2019
bb3310d
init module secret eng mgmt
drewmullen Jun 3, 2019
4684e46
deprecate nonconformative modules
drewmullen Jun 3, 2019
0d4725a
disable test until hvac 9.2 is released
drewmullen Jun 3, 2019
8e25519
fix idempotence check for eng config
drewmullen Jun 4, 2019
2220906
fix idempotent checks az auth cfg
drewmullen Jun 4, 2019
9d17e88
revert deprecated name change, docs failing
drewmullen Jun 4, 2019
7fdd60e
fix idempotence check for auth_method
drewmullen Jun 4, 2019
a283ca0
wip
drewmullen Jun 4, 2019
c892e4f
nocows =1 by default
drewmullen Jun 4, 2019
79a8868
quoting docstring dictionaries
drewmullen Jun 6, 2019
225acfe
default var causing doc job failure?
drewmullen Jun 7, 2019
0bd59ab
replace non-problems with original changes
drewmullen Jun 7, 2019
d29a420
hvac 9.2 required
drewmullen Jun 10, 2019
de33a46
enable tests
drewmullen Jun 10, 2019
a8f02ff
fix tests but remain disabled
drewmullen Jun 10, 2019
723f695
fix function name and un/pw vars
drewmullen Jun 10, 2019
41d0101
upgrade test framework to 3.7. hold breath"
drewmullen Jun 10, 2019
0fc7868
remove required check
drewmullen Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
default var causing doc job failure?
  • Loading branch information
@drewmullen
drewmullen committed Jun 7, 2019
commit 225acfe133347d96423ec0f7515517a567408007
2 changes: 1 addition & 1 deletion ansible/modules/hashivault/hashivault_auth_method.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
config:
description:
- configuration set on auth method. expects a dict
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document seems wrong to me like this should be a yaml dictionary rather than a string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you talking about the default line? yeah, interestingly it works either way. when i first submitted the PR it was in standard {} format but after i started getting the sphinx issues i was messing with the format because i didnt know what was borking it.

i agree though, the doc example should show without the ", though it does work either way

default: "{'default_lease_ttl': 2764800, 'max_lease_ttl': 2764800, 'force_no_cache':False, 'token_type': 'default-service'}"
default: "dictionary with default_lease_ttl, max_lease_ttl, token-type, and force_no_cache defaulted"
'''
EXAMPLES = '''
---
Expand Down
2 changes: 1 addition & 1 deletion ansible/modules/hashivault/hashivault_secret_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
config:
description:
- config of secret backend
default: "{'default_lease_ttl': 2764800, 'max_lease_ttl': 2764800, 'force_no_cache': False}"
default: "dictionary with default_lease_ttl, max_lease_ttl, and force_no_cache defaulted"
state:
description:
- state of secret backend
Expand Down