Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cesium: stop casting void to any #7189

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Cesium: stop casting void to any #7189

merged 1 commit into from
Oct 22, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Jun 6, 2024

What this PR does

The type checking will pass without
cast.

Test me

Tested by CI.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@pjonsson
Cesium: stop casting void to any
b067b76 
The type checking will pass without
cast.
na9da
na9da approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pjonsson

@na9da na9da merged commit eef4b5d into TerriaJS:main Oct 22, 2024
5 checks passed
@pjonsson pjonsson deleted the cesium-no-cast branch October 25, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na9da na9da na9da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjonsson @na9da