UI related stories #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
search bar & logo sticky"
- Minimizes distractions between the card vs. the map - Removes the need to make certain parts of the card sticky, since everything important is in view all the time - More fleshed out styling for stories - Typographic improvements for all page elements, including a rudimentary modular scale for headings and paragraphs - Addition of search form affordance (not yet wired up to anything) - Ability to hide and show the card to allow the user to concentrate on the map when desired. - There may be more, but these are the big tickets.
- Moves the intro content out of the sidecard and into its own component. Allows the sidebar card more space for functionality.
- Enables built-in Mapbox nav, which doesn't have an opinion about "up/down" vs. "north/south"
mirandawang
reviewed
Aug 31, 2018
| constructor(props){ | ||
| super(props); | ||
| this.state = { isPopped: true } | ||
| this.handleIntroPopup = this.handleIntroPopup.bind(this); |
There was a problem hiding this comment.
How do you feel about using the fat arrow function syntax to get around having to bind every function to this? I'm not sure if there's really a difference between the two ways, but it could save you some typing in the future :)
So in the function declaration, instead of
handleIntroPopup () {
// stuff
}
you can do
const handleIntroPopup = () => {
// stuff
}
and you'll have access to this context, so you won't need to bind it in the constructor.
There was a problem hiding this comment.
Absolutely, @mirandawang! Good catch and I learned something :)
There was a problem hiding this comment.
Thanks for updating! :) So you should be able to delete all the .bind() references now!
There was a problem hiding this comment.
Done and done :)
- Uses fat arrow syntax - Fixes class vs. className error
- Removes uneeded call to `bind` in constructor - Removes uneeded `proptypes` import
mirandawang
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work (hopefully) closes or obviates several stories related to the map card/sidebar.
I realize this is a big PR that touches a lot of things, and I don't necessarily require approval now since this is my "ui branch". Just wanted everyone to be aware so I can gather reactions, and keep pushing other items into this branch.