Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#406] Add validation and attribute settings for Story model #421

Merged

Conversation

slaloggia
Copy link
Contributor

  • Validates presence of at least one speaker
  • Makes interviewer and interview_location optional

@auto-comment
Copy link

auto-comment bot commented Apr 7, 2020


Thank you for your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
Best,
@terrastories-stewards

@slaloggia slaloggia force-pushed the 406-story-attribute-validation branch from 4639fdf to d207efb Compare April 18, 2020 19:24
- Validate presence of speaker_stories for creation of Story
- Make interview-location and interviewer optional for creation of Story
@slaloggia slaloggia force-pushed the 406-story-attribute-validation branch from d207efb to 0ac06ed Compare April 18, 2020 19:45
- Test validation of speakers, through speaker_stories
- Make interviewer and interview_location optional in association tests
- Create traits for interviewer/interview_location and speakers in the story factory
Copy link
Contributor

@FeminismIsAwesome FeminismIsAwesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FeminismIsAwesome FeminismIsAwesome merged commit 145ae99 into Terrastories:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants