Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Value::XXXMember(...) overloads for std::string #335

Merged
merged 1 commit into from
May 14, 2015

Conversation

miloyip
Copy link
Collaborator

@miloyip miloyip commented May 12, 2015

Try to replace the PR #333
Would like to invite @pah to review.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.82% when pulling 2786103 on member_stdstring into 7562d02 on master.

@pah
Copy link
Contributor

pah commented May 13, 2015

As mentioned in #333, these functions have been omitted from the original std::string support (#107).
It is a good idea to add them now. For completeness, we should add PushBack overloads as well, though.

One of the main reasons for omitting AddMember( ..., const std::string&, ... ) is the explosion of the overload set if we want to support std::string as a key parameter as well. But this will likely pop up soon, too. ;-)

LGTM, otherwise. 👍

@miloyip
Copy link
Collaborator Author

miloyip commented May 14, 2015

Actually I have tried adding some overloads for AddMember(const std::string&, ...) but it will causes ambiguity error for some AddMember(const Ch*, ...) calls. PushBack() also have similar problem.
So I think this is it.

miloyip added a commit that referenced this pull request May 14, 2015
Add Value::XXXMember(...) overloads for std::string
@miloyip miloyip merged commit 424abf1 into master May 14, 2015
@miloyip miloyip deleted the member_stdstring branch May 16, 2015 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants