Move to RFC7159 (closes #90) #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the allowance of arbitrary root value types, the individual tests can use the top-level Parse functions, instead of ParseFoo() variants. Secondly, some unneeded array wrappers have been dropped and non-singular tests starting with other values than objects or arrays have been added.
By adding an optional CRTP template parameter, the BaseReaderHandler can call the "overridden" `Default()` function from the `Derived` class. See https://en.wikipedia.org/wiki/Curiously_recurring_template_pattern
pah
added a commit
to pah/rapidjson
that referenced
this pull request
Aug 11, 2014
This drops #3 and #4, as their functionality has been superseded upstream, see Tencent/rapidjson#97 and Tencent/rapidjson#101. Conflicts: include/rapidjson/prettywriter.h include/rapidjson/reader.h include/rapidjson/writer.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #90, the restriction to object or array root elements has been dropped with the updated JSON RFC (RFC7159). This pull-request removes the restriction from the RapidJSON implementation.
The unit tests are updated to check the new behaviour.
@thebusytypist: Could you please review the changes to the iterative parser (c9f2715)? (The whitespace changes have been fixed in 453eda5)