Remove include of gtest_prod.h

[autopear]

Currently we use flare's fiber in our project, which cannot include any googletest headers in the production environment. IMO, release headers should not include gtest. To test against certain private/protected class members, you can add some test-specific APIs to access these members. Similar methods can be applied to other components like hbase and rpc.

[0x804d8000]

I'm not sure this is my preferred way to address the issue.

My concern is that exposing these internal methods, albeit with a TEST prefix, makes public interfaces ugly. Especially with auto-completion enabled, IDE will list them out regardless of their prefix.

If linking against gtest is a concern, maybe we can instead provide our own gtest_prod.h in flare/testing and include it in headers you're modifying instead. That header is simple enough for us to roll our own.

[autopear]

I think you proposed method is better. However, I'm not sure how this is possible in bazel/blade. You need to add come build time option to enable include of the actual gtest_prod.h or the customized one with empty defines for FRIEND_TEST, and linking against gtest_prod.

[0x804d8000]

Guess I wasn't clear about my proposal.

What I meant was to always use flare/testing/gtest_prod.h. We can implement our own FRIEND_TEST in this new header, and get rid of gtest's header altogether.

This should be relatively easy to do, as FRIEND_TEST is just a macro expanding to friend class.

[0x804d8000]

Sorry for the late reply, been busy these days..

I've commented inline.

Bazel build is also failing due to missing bazel target for test_prod.h. (Previously bazel build failed too, but not for the same reason. It was mostly a environment issue. I'm trying to fix it in #153 )

[0x804d8000]

I've merged aforementioned PR. You can now pull changes from master to verify that your changes pass all CIs.

Thanks for the contribution 🙏.

---

A few tests aren't stable and fail under high load, which does happen in GitHub runners, they can be safely ignored.

[autopear]

All comments are addressed. However, I'm not sure why some tests are failing. Can you take a look?

[0x804d8000]

Some load-sensitivity tests, though I didn't expect them to fail so frequently.

I retried them and now all of them passed.

Merged, thanks!