feat(endpoint): add unix domain socket #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x804d8000
reviewed
Aug 22, 2023
flare/base/net/endpoint.cc
Outdated
| @@ -37,7 +38,9 @@ namespace flare { | |||
|
|
|||
| namespace { | |||
|
|
|||
| std::string SockAddrToString(const sockaddr* addr) { | |||
| constexpr auto offset_sun_path = offsetof(sockaddr_un, sun_path); | |||
| @@ -369,6 +395,33 @@ std::optional<Endpoint> TryParseTraits<Endpoint>::TryParse(std::string_view s, | |||
| return er.Build(); | |||
| } | |||
|
|
|||
| // TODO(kangjinci): almost always succeeds, need to distinguish between ipv4 and | |||
There was a problem hiding this comment.
ipv4和ipv6传进去应该失败？如果把这个加到TryParse(std::string_view s)里就要考虑了，比方192.0.0.1.2这种非法ip，传进去TryParse还是会成功
There was a problem hiding this comment.
明白了，这样确实不太好。那默认只解析v4/v6，然后支持手动传入from_unix来明确解析unix domain就可以了
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.