Monk corks

[jf647]

This adds a basic Monk module with support for Stances and Legacy of the Emperor raid buffing.

The whole blessing-style buff probably needs to get pulled out into a template, because if you include the Hunter Shale Spider pet there are four sources for the 5% buff now.

[tekkub]

I've been working on Legacy of the Emperor myself, I have a few changes to it now that there's added complexity here (yes, that's right, simplifying them down to 8 buff classes made shit more complex).

I don't have a high enough level monk to understand stances yet, can you explain them to me? When I looked at them it seemed like each was spec-specific, so the player would never actually choose to cast one. It also seemed like they persisted through death, so the player didn't need to worry about forgetting to cast it.

[jf647]

Conceptually they are like stances, except that everyone gets the DPS stance (Fierce Tiger). When you switch specs, you are always in Fierce Tiger, which is what drove the module - I'd swap from Tank to Heals in a dungeon, then get a bunch of "you need to be in Serpent Stance to cast that" errors.

There are also no benefits (that I can see) for a Tank or Healer to be in the DPS stance.

It would make much more sense if a spec swap just put you into the "proper" stance, but it doesn't (at least not yet - perhaps that's a Blizz bug). Non-Windwalkers have to choose their stance after swapping or they can't cast half their spells.

I don't see a problem treating them like Paladin Seals or DK Presences - it may be useless for pure DPS monks, but works just fine for Tanks and Healers.

[tekkub]

Ok, so the player does need a reminder. That's a shitty design it sounds like, I would think they would be a passive thing given by the spec.

But then, I would also have made the "core 8" buffs all passive too. Got a druid? Everyone has Mark. Done. There is never any decision made about if a buff should be cast or not except paladin blessings... it's so dumb. But I digress.

I'll get things merged here shortly, after I do is there any way you could test a little with a druid and a pally? Emp should show up in cork in all cases it's needed, including when you have a druid and pally and the pally casts kings (which is the same buff as emp). Cork should know that the pally should give Might in that case, and therefore tell you to overwrite kings with emp.