Artifact Power Items support #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that this does not yet work for non-English locales. WowHead has a list of the spells (deDE locale in this case). Best would probably be to pick one of these spell ids and compare against the name returned by |
|
Awesome addition. I've merged it with what should be a more robust localization. |
|
Awesome! However I think you got the wrong translation. There seems to be more than just the artifact empowering effects named "Empowering", that's why I linked the German list :) " |
|
@tekkub Oh, nevermind, I must have been looking at the PR code instead of the actual commit. My bad, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.