Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifting Login Page to centre #338

Open
NOiR-07 opened this issue Jun 29, 2021 · 18 comments
Open

Shifting Login Page to centre #338

NOiR-07 opened this issue Jun 29, 2021 · 18 comments
Assignees
Labels
Hactoberfest 🤩 Up for Grab This issue will is not assigned ! Grab It !

Comments

@NOiR-07
Copy link
Contributor

NOiR-07 commented Jun 29, 2021

I'm an LGMSOC participant, as we see the login page slightly upwards so I will shift the login page to the centre of the page to look better

@welcome
Copy link

welcome bot commented Jun 29, 2021

Hello there!👋 Welcome to the project!🚀⚡
Thank you and congrats🎉 for opening your very first issue in this project. Athavani is a full-stack MERN Tool built in order to save all your memories in a single place and rejoice them through the years. Please adhere to our Code of Conduct. Please make sure not to start working on the issue, unless you get assigned to it.😄

@ChitvanRamani22 ChitvanRamani22 added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 30, 2021
@ChitvanRamani22
Copy link
Collaborator

@NOiR-07 any updates?

@NOiR-07
Copy link
Contributor Author

NOiR-07 commented Jul 3, 2021

@NOiR-07 any updates?

Sir, i can't find the file where code of login page is written

@ChitvanRamani22
Copy link
Collaborator

It's in client/src/components/auth

@NOiR-07
Copy link
Contributor Author

NOiR-07 commented Jul 3, 2021

It's in client/src/components/auth

BUT THERE IS NO HTML FILE

@ChitvanRamani22
Copy link
Collaborator

We work on react to we have js file

@NOiR-07
Copy link
Contributor Author

NOiR-07 commented Jul 3, 2021

We work on react to we have js file

OKAY

@heet-kumar
Copy link
Contributor

@NOiR-07 you know the react js .

@NOiR-07
Copy link
Contributor Author

NOiR-07 commented Jul 3, 2021

@NOiR-07 you know the react js .

not much

@sanjay270899 sanjay270899 linked a pull request Jul 6, 2021 that will close this issue
@AmeyaJain-25 AmeyaJain-25 added the 🤩 Up for Grab This issue will is not assigned ! Grab It ! label Aug 9, 2021
@SS-Ace
Copy link

SS-Ace commented Sep 20, 2021

Respected mentor,
I am a participant from "Developer Days". Can i also contribute to this?

@adarsh45
Copy link

Hello mentor,
I would like to take up this issue !
I am into MERN development since last 1 year
Understanding basic css can easily solve this issue
But my knowledge about grid, flexbox would really help me!

@Tejas1510
Copy link
Owner

Go ahead @adarsh45

@adarsh45
Copy link

adarsh45 commented Oct 1, 2021

@Tejas1510 the deployed site and the one in code (/client) are different
And in the repo's code there is no need to center, as it is already done
Is there any different branch to work on this issue ?

@AmeyaJain-25
Copy link
Collaborator

I think it's done... You can vertically align them @adarsh45

Give a minHeight of 100vh and can bring the card at center vertically

@AmeyaJain-25 AmeyaJain-25 removed the LGMSOC21 This issue will be considered for LGM-SOC 21 label Oct 1, 2021
@onifs10
Copy link
Contributor

onifs10 commented Oct 7, 2021

hello is this issue assign to anyone or is it resolved ?

@AmeyaJain-25
Copy link
Collaborator

You can go ahead @onifs10

@AmeyaJain-25 AmeyaJain-25 assigned onifs10 and unassigned adarsh45 Oct 7, 2021
@AmeyaJain-25
Copy link
Collaborator

Hosted link isn't updated.
And you have to align the box vertically center

@onifs10
Copy link
Contributor

onifs10 commented Oct 8, 2021

Alright

Tejas1510 added a commit that referenced this issue Oct 10, 2021
Fixed Login and SignUp page #338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hactoberfest 🤩 Up for Grab This issue will is not assigned ! Grab It !
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants