[Feat] #63 사진 추가 API 연결 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joon9750
approved these changes
Jul 7, 2023
i-colours-u
reviewed
Jul 7, 2023
Comment on lines
+110
to
+118
| private func fetchMultiPartData() -> [MultipartFormData]? { | ||
| if let imageData = photoImage.jpegData(compressionQuality: 0.8) { | ||
| let imageDataProvider = Moya.MultipartFormData(provider: MultipartFormData.FormDataProvider.data(imageData), name: "photo", fileName: "image.jpg", mimeType: "image/jpeg") | ||
| let albumIDDataProvider = Moya.MultipartFormData(provider: .data("\(albumID)".data(using: .utf8) ?? .empty), name: "albumId") | ||
| let dateProvider = Moya.MultipartFormData(provider: .data("\(dateTaken)".data(using: .utf8) ?? .empty), name: "takenAt") | ||
| let studioIDProvider = Moya.MultipartFormData(provider: .data("\(studioID)".data(using: .utf8) ?? .empty), name: "studioId") | ||
| return [imageDataProvider, albumIDDataProvider, dateProvider, studioIDProvider] | ||
| } else { return nil } | ||
| } |
There was a problem hiding this comment.
Moya를 쓰게 된다면 보통은 ~~~API 객체 내에서 MultipartFormData를 직접 가공하고 만드는 방식으로 보통 구성을 하게 됩니다!
다른 화면에서도 범용적으로 쓸 수 있도록 필요한 정보만 넘기고( 여기서는 날짜, studioID, 이미지 데이터 등등.. 이 되겠죠?) Moya 객체쪽으로 넘기는 편이에요!
(나중에 시간날 때 한번 수정해보세요!)
There was a problem hiding this comment.
저도 데이터를 가공하면서 이게 맞나 싶었는데 감사합니다! 꼭 수정해보겠습니다!!!
|
제일 확실한건 옆에 서버 사람 1명 앉혀두고, 사진 들어왔는지 체크하는게 젤 빠른것 같아요 ^^... |
Joon9750
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
🔥 사진 추가 POST가 MultipartData여서 네트워크 세팅 부분 수정하고
사진 추가 뷰에 POST 구현했습니다.
PR Point
!! MultipartData도 열심히 찾아서 구현해봤는데 맞는 방법인지 잘 모르겠습니다..
✅ TestImage 넣고 POST해봤을 때 성공 잘 찍힙니다!
관련 이슈