[Chore] #112 - 온보딩에서 진입시 네비바 실종 이슈 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
PR Point
온보딩에서 네비바를 hide시키면 네비게이션 컨트롤러 자체가 사라지는 이유로 hideNavbar()을 삭제하고 온보딩View의 레이아웃을 애플로그인 버튼 기준으로 다시 잡아주었습니다!
준혁이 담당 AlbumDetailViewController에서는 showNavigationBar() 지우면 작동할거에요. ButtonAction은 BaseVC에 있는 메서드 override해서 구현해주세요~
*
스크린샷
관련 이슈