Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of the documentation. #9

Merged
merged 13 commits into from
Mar 1, 2019
Merged

Conversation

snappyapple632
Copy link
Contributor

I've changed a lot of things throughout. Please check for any empty links or anything else I could have missed.

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I've made some smaller suggestions, mostly typos.

docs/00_Prepare_everything.md Outdated Show resolved Hide resolved
docs/05_releasing.md Outdated Show resolved Hide resolved
docs/06_documentation.md Outdated Show resolved Hide resolved
docs/06_documentation.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/00_Prepare_everything.md Outdated Show resolved Hide resolved
docs/00_Prepare_everything.md Outdated Show resolved Hide resolved
TobiGr and others added 5 commits February 28, 2019 08:03
Co-Authored-By: snappyapple632 <[email protected]>
Co-Authored-By: snappyapple632 <[email protected]>
Co-Authored-By: snappyapple632 <[email protected]>
Co-Authored-By: snappyapple632 <[email protected]>
@theScrabi
Copy link
Member

theScrabi commented Feb 28, 2019

@snappyapple632 CI failes, please make sure there are no dengling links in the documentation.
Nice work so far though.

@snappyapple632
Copy link
Contributor Author

Alright, I'll do another run through the docs tonight and fix the rest of the issues here. @theScrabi , can you provide the specific links that aren't working?

@TobiGr
Copy link
Member

TobiGr commented Feb 28, 2019

I don't think that it's your fault. As you can see here, the link checks failed on the master branch, too.

@snappyapple632
Copy link
Contributor Author

All the links are fixed now. It's ready for final review.

@theScrabi theScrabi merged commit ccf8787 into TeamNewPipe:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants