Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some other release instruction fixes #46

Merged
merged 3 commits into from
Aug 28, 2022
Merged

Some other release instruction fixes #46

merged 3 commits into from
Aug 28, 2022

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Aug 27, 2022

  • Add some tips (login to weblate, newline at the end of the changelog)
  • Add missing (but unneeded unless branches were switched) git checkout dev
  • Fix testing-apks internal link
  • Expand on how the PR description should be created
  • Add more instructions for building a testing release APK

@Stypox
Copy link
Member Author

Stypox commented Aug 27, 2022

Done @opusforlife2

opusforlife2
opusforlife2 approved these changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@opusforlife2 opusforlife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval is only for the language part, of course.

@TobiGr TobiGr merged commit 3929a28 into TeamNewPipe:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

@opusforlife2 opusforlife2 opusforlife2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stypox @TobiGr @opusforlife2