Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Maintainers' Section #12

Merged
merged 17 commits into from
Aug 17, 2019
Merged

Conversation

snappyapple632
Copy link
Contributor

Fixed a bunch of grammatical errors, clarified some points made and restructured a few parts to keep them parallel.

Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed half of this PR. There's a few things I'd change.

docs/07_maintainers_view.md Show resolved Hide resolved
docs/07_maintainers_view.md Outdated Show resolved Hide resolved
docs/07_maintainers_view.md Outdated Show resolved Hide resolved
docs/07_maintainers_view.md Outdated Show resolved Hide resolved
docs/07_maintainers_view.md Outdated Show resolved Hide resolved
docs/07_maintainers_view.md Outdated Show resolved Hide resolved
docs/07_maintainers_view.md Outdated Show resolved Hide resolved
docs/07_maintainers_view.md Outdated Show resolved Hide resolved
@TheAssassin
Copy link
Member

Thanks for this kind of PR. Improvements in grammar, spelling and wording are always highly appreciated. I reviewed a part of your changes, please see above.

snappyapple632 and others added 3 commits August 4, 2019 15:41
Co-Authored-By: TheAssassin <[email protected]>
Co-Authored-By: TheAssassin <[email protected]>
Co-Authored-By: TheAssassin <[email protected]>
07_maintainers_view.md Outdated Show resolved Hide resolved
@TobiGr
Copy link
Member

TobiGr commented Aug 17, 2019

No you added a complete new folder with additional 56 files 😅

@snappyapple632
Copy link
Contributor Author

Okay, hopefully I fixed all of it now.

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small thing is left.

docs/07_maintainers_view.md Outdated Show resolved Hide resolved
@TobiGr TobiGr merged commit 095dc71 into TeamNewPipe:master Aug 17, 2019
@TobiGr
Copy link
Member

TobiGr commented Aug 17, 2019

Thanks again!

@snappyapple632
Copy link
Contributor Author

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants