-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update admin list utility to recognise eosIDs #347
Update admin list utility to recognise eosIDs #347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Approved
How does this work when utilising the list? A lot of the Server class seems to search the list of admins by Steam IDs still, e.g.: Line 357 in 9f9755e
|
@Thomas-Smyth I'm building a full migration to eosIDs. I'm planning to implement a mapping function that will convert steamIDs of online admins into eosIDs (non-matching IDs will be ignored instead of failing). This will allow us to support old steamID-based admin lists while people shift their stuff to eosIDs. My future PR builds upon this PR and my own: #352 |
it accepts both steamID and eosID |
How? If it's always looking up by Steam ID then it will never match on a EOSID. |
People will have to adjust their plugins in order to use eosID, but this PR improves how the admin lists are parsed and won't skip the lines with an eosID only, and doesn't make a specific discrimination between steamID and eosID |
If an ID is used directly in rcon commands then it will work regardless. There are 2 plugins that will ignore eosIDs because they loop through players matching admin IDs against steamID:
But I'm planning to address this in my next PR. |
Pending further review. |
So, I updated my admins.cfg to have EOSIDs for my Admins after that whole EOS Update, guess SquadJS hasn't been pulling them this whole time. Now it does.