Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamps option to logger configuration #327

Closed
wants to merge 2 commits into from

Conversation

sergelouie6
Copy link
Contributor

This is in line with #271

@Thomas-Smyth
Copy link
Collaborator

If we think that timestamps should be off by default - I am open to that debate - it should be made the default through the code rather than the config files. In either case, this pull request does not change the template files, and thus it will be overwritten by husky whenever someone commits (it appears husky was not run when you made these commits). Given there does not appear to be much support for changing the default behaviour on this pull request and the issues with how the change is implemented, I am going to close this pull request. If you think timestamps should be off by default, please implement it as default through the code and then open a new pull request. However, that will only be accepted if there is a wider agreement that it should be the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants