Fixed Status Monitor Overlay issue #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for this PR but this has already been fixed on the dev branch. We're perparing for a new release of DeepSea right now and we basically stage everything in there before pushing everything to the master branch. |
|
Oh I gotcha, no worries. I should've checked.
…On Sat, May 11, 2024 at 4:44 PM hax4dazy ***@***.***> wrote:
Hey thanks for this PR but this has already been fixed on the dev branch.
We're perparing for a new release of DeepSea right now and we basically
stage everything in there before pushing everything to the master branch.
—
Reply to this email directly, view it on GitHub
<#136 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABV2AEL6QM5IWDPKFGCBTQLZB2GKNAVCNFSM6AAAAABHSFZOTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGAZTQMZQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master branch encounters a file not found error with Status Monitor Overlay module due to the release assets being changed to a zip archive in Release 1.0.0.
The fix is to update the regex and change to an extract step in settings.json. The zip archive already contains the switch/.overlays folder, so create_dir is no longer necessary.