Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#81] splash api 연결 및 tendency result api / UI 작업 #90

Merged
merged 14 commits into from
Jan 12, 2024

Conversation

chattymin
Copy link
Member

@chattymin chattymin commented Jan 12, 2024

⛳️ Work Description

  • splash api 연결
  • tendnecy result api 연결
  • tendnecy result UI 수정사항 반영
  • 분기처리 및 화면이동 조정

📸 Screenshot

스크린샷 2024-01-12 오후 10 27 57

📢 To Reviewers

  • 이미지 저장만 하면 끝~
  • 드디어 끝나간다

@chattymin chattymin added 동민 🐥 FEAT ✨ 새로운 기능 구현 labels Jan 12, 2024
@chattymin chattymin self-assigned this Jan 12, 2024
@chattymin chattymin changed the title [Feat/#81] splash api 연결 및 [Feat/#81] splash api 연결 및 tendency result api / UI 작업 Jan 12, 2024
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API 연결하느라 수고하셨습니다!!!!!!

Comment on lines +48 to +55
when (state) {
AuthState.LOADING -> return@onEach
AuthState.SUCCESS -> navigateToDashBoardScreen()
AuthState.FAILURE -> navigateToSignInScreen()
AuthState.SIGNUP -> return@onEach
AuthState.SIGNIN -> return@onEach
AuthState.TENDENCY -> navigateToTendencyScreen()
AuthState.EMPTY -> return@onEach
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 state 상태가 많군요

Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바람직합니다.

Comment on lines +38 to +40
override suspend fun getSplash(): Result<Unit> = kotlin.runCatching {
authDataSource.getSplash()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코틀린을 사랑하는 마음이 담겨있네요

Comment on lines +12 to +13
) : ProfileRepository {
override suspend fun getUserProfile(): Result<UserProfileRequestModel> = runCatching {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

줄바꿈이 좋을 것 같아요 ~

Comment on lines 20 to 23
) : ViewModel() {
private val _userState = MutableStateFlow(AuthState.LOADING)
val userState: StateFlow<AuthState> = _userState
fun getHasAccessToken(): Boolean = tokenRepository.getAccessToken().isNotBlank()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

줄이..아쉽네요

Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리얼 갓동민 코멘트 달 게 업네욥

최고십니다~!!!!~!

Comment on lines +3 to +5
enum class AuthState {
LOADING, SUCCESS, FAILURE, SIGNUP, SIGNIN, TENDENCY, EMPTY
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오@!@! signup, signin, tendency도 있군요!

@chattymin chattymin merged commit 934ab8e into develop Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT ✨ 새로운 기능 구현 동민 🐥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] splash & tendencyResult / api 연결 & UI 수정사항 반영
4 participants