[Feat/#71] 설정창 / 로그아웃, 회원탈퇴 api 연결 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crownjoe
approved these changes
Jan 11, 2024
Comment on lines
9
to
13
| @PATCH("api/users/signout") | ||
| suspend fun patchSignOut(): SignOutResponseDto | ||
|
|
||
| @DELETE("api/users/withdraw") | ||
| suspend fun deleteWithDraw(): NullableBaseResponse<String?> |
There was a problem hiding this comment.
patch부터 delete까지................미춰따
Comment on lines
50
to
58
| private fun observeUserSignOutState() { | ||
| viewModel.userSignOutState.flowWithLifecycle(lifecycle).onEach { state -> | ||
| when (state) { | ||
| true -> restartApp(requireContext()) | ||
| false -> toast(getString(R.string.server_error)) | ||
| null -> {} | ||
| } | ||
| }.launchIn(lifecycleScope) | ||
| } |
leeeyubin
approved these changes
Jan 11, 2024
Comment on lines
11
to
13
|
|
||
| @DELETE("api/users/withdraw") | ||
| suspend fun deleteWithDraw(): NullableBaseResponse<String?> |
There was a problem hiding this comment.
DB 정보를 Delete 할때 쓴답니다~
Comment on lines
+70
to
+72
| context.startActivity(Intent.makeRestartActivityTask(componentName)) | ||
| Runtime.getRuntime().exit(0) | ||
| } |
Marchbreeze
approved these changes
Jan 11, 2024
Comment on lines
15
to
17
| override suspend fun deleteWithDraw(): Result<String?> = kotlin.runCatching { | ||
| settingDataSource.deleteWithDraw().data | ||
| } |
| import retrofit2.http.PATCH | ||
|
|
||
| interface SettingService { | ||
| @PATCH("api/users/signout") | ||
| suspend fun patchSignOut(): SignOutResponseDto | ||
|
|
||
| @DELETE("api/users/withdraw") | ||
| suspend fun deleteWithDraw(): NullableBaseResponse<String?> |
There was a problem hiding this comment.
그래서 수정했습니다!!
상호님도 수정해줘요 ㅎㅎㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers