[UI/#51] 설정 뷰 / UI 구현 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jan 10, 2024
Comment on lines
11
to
12
| private lateinit var quitDialog: SettingQuitDialogFragment | ||
| private lateinit var logoutDialog: SettingLogoutDialogFragment |
There was a problem hiding this comment.
nullable한 dialog로 초기값 null로 설정해서 전역변수를 생성한 뒤, 생성할때만 실제 객체를 연결해주고, onDestroy때 dissmiss() 해준다면 메모리 누수를 더 방지할 수 있습니다~~
제 투두생성 시 바텀시트 올리는 코드 참고해보시면 좋을듯 !
Comment on lines
44
to
45
| private fun initAboutDoorip() { | ||
| binding.btnSettingAboutDooripEnter.setOnSingleClickListener { |
Comment on lines
143
to
153
| <TextView | ||
| android:id="@+id/btn_setting_service_version_enter" | ||
| style="@style/TextAppearance.Doorip.Detail1.Regular" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginEnd="16dp" | ||
| android:textColor="@color/gray_300" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| tools:text="v1.0" /> |
There was a problem hiding this comment.
요친구 buildSrc의 version에 있는 1.0 을 활용해서 나중에 버전 업할때 대응 가능하도록 적용시켜주세요!
crownjoe
approved these changes
Jan 10, 2024
Comment on lines
26
to
27
| WindowManager.LayoutParams.MATCH_PARENT, | ||
| WindowManager.LayoutParams.MATCH_PARENT, |
There was a problem hiding this comment.
요 아이때문에 다이얼로그가 화면 꽉 차게 안나와서 애먹은게 새록새록하네요 ㅎ.ㅎ
| WindowManager.LayoutParams.MATCH_PARENT, | ||
| WindowManager.LayoutParams.MATCH_PARENT, | ||
| ) | ||
| setBackgroundDrawableResource(R.color.transparent_60) |
chattymin
approved these changes
Jan 10, 2024
Comment on lines
1
to
6
| <?xml version="1.0" encoding="utf-8"?> | ||
| <shape xmlns:android="https://schemas.android.com/apk/res/android" | ||
| android:shape="rectangle"> | ||
| <solid android:color="@color/white_000" /> | ||
| <corners android:radius="2dp" /> | ||
| </shape> |
There was a problem hiding this comment.
네이밍 참고해주세용~~~~~~~ rect_2입니다 우하하
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
device-2024-01-10-202953.mp4
📢 To Reviewers