[UI/#50] 프로필 뷰 구현 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Jan 9, 2024
Comment on lines
3
to
15
| data class ProfileMock( | ||
| val profileTitle: String, | ||
| val profileSubTitle: String, | ||
| val tags: List<String>, | ||
| val profileBoxInfo: List<BoxInfo>, | ||
| ) { | ||
| data class BoxInfo( | ||
| val title: String, | ||
| val first: String, | ||
| val second: String, | ||
| val third: String, | ||
| ) | ||
| } |
There was a problem hiding this comment.
내부 변수명만 다른 완벽히 같은 클래스가 이미 존재하네용~
그걸 재활용 하는 것이 좋아보입니다!!
There was a problem hiding this comment.
감사합니답 재활용하도록 수정했습니다~~~!!!!!!!👍👍
Marchbreeze
approved these changes
Jan 9, 2024
Comment on lines
14
to
15
| private val profileViewModel by viewModels<ProfileViewModel>() | ||
| override fun onCreate(savedInstanceState: Bundle?) { |
…into ui/#50-create-profile
Marchbreeze
approved these changes
Jan 9, 2024
app/src/main/AndroidManifest.xml
Outdated
Comment on lines
120
to
121
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240110_050901_doorip.mp4
📢 To Reviewers