[UI/#35] splash screen 구현 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jan 8, 2024
Comment on lines
101
to
104
| object GooglePlayDependencies { | ||
| const val update = "com.google.android.play:app-update:${Versions.googlePlayUpdate}" | ||
| const val updateKtx = "com.google.android.play:app-update-ktx:${Versions.googlePlayUpdate}" | ||
| } |
There was a problem hiding this comment.
요 친구들도 지금 자동 업데이트 기능 지금 안쓸거면 지금은 필요없을 듯 합니닷
buildSrc/src/main/kotlin/Versions.kt
Outdated
| @@ -41,6 +41,7 @@ object Versions { | |||
| const val junitVersion = "4.13.2" | |||
| const val espressoVersion = "3.3.0" | |||
| const val androidTestVersion = "1.1.2" | |||
| const val googlePlayUpdate = "2.1.0" | |||
| import android.net.ConnectivityManager | ||
| import android.net.NetworkCapabilities | ||
|
|
||
| object NetworkManager { |
| import timber.log.Timber | ||
|
|
||
| class SplashActivity : BaseActivity<ActivitySplashBinding>(R.layout.activity_splash) { | ||
| private val appUpdateManager by lazy { AppUpdateManagerFactory.create(this) } |
| isConnectedNetwork() | ||
| } | ||
|
|
||
| private fun isConnectedNetwork() { |
There was a problem hiding this comment.
변수 이름으로는 is가 적합하지만, 함수명으로는 check가 더 어울릴 것 같습니당
| finish() | ||
| } | ||
|
|
||
| private fun requestUpdate(appUpdateInfo: AppUpdateInfo) { |
| <string name="notice">안내</string> | ||
| <string name="okay">확인</string> | ||
| <string name="internet_connect_error">인터넷 연결을 확인해주세요</string> | ||
| <string name="splash_update_error">업데이트에 문제가 생겼어요\n다시 시도해주세요</string> |
There was a problem hiding this comment.
나머지는 network 연결 에러시 dialog에도 사용되기 때문에 마지막만 지우도록 하겠습니다~
Comment on lines
+62
to
+64
| <style name="splash_delete" parent="Base.Theme.Doorip"> | ||
| <item name="android:windowIsTranslucent">true</item> | ||
| </style> |
There was a problem hiding this comment.
요 친구는 아이템 하나인 것 같은데, 무슨 기능을 위해 사용되나요?
There was a problem hiding this comment.
기존에 존재하는 splashScreen을 제거하는 기능을 합니다!!
이게 없으면 splash가 두개가 떠용
crownjoe
approved these changes
Jan 8, 2024
Comment on lines
+68
to
+72
| private fun navigateToSignInScreen() { | ||
| Intent(this, SignInActivity::class.java).apply { | ||
| startActivity(this) | ||
| } | ||
| finish() |
| .build(), | ||
| ) | ||
| }.onFailure { | ||
| Timber.e(it) |
leeeyubin
approved these changes
Jan 8, 2024
Comment on lines
+44
to
+47
| .setPositiveButton( | ||
| R.string.okay, | ||
| ) { _, _ -> | ||
| finishAffinity() |
Comment on lines
53
to
60
| Handler(Looper.getMainLooper()).postDelayed({ | ||
| navigateToSignInScreen() | ||
| if (false) { // 자동 로그인 판정으로 변경 예정 | ||
| navigateToMainScreen() | ||
| } else { | ||
| navigateToSignInScreen() | ||
| } | ||
| }, 3000) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
2024-01-08.7.13.01.mov
📢 To Reviewers