-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR/#191] chart CustomView 구현 및 적용 #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주조아용 최~고
import com.going.presentation.databinding.ViewChartTextviewBinding | ||
import com.going.ui.extension.setBulletPoint | ||
|
||
class ChartTextView(context: Context, attrs: AttributeSet) : ConstraintLayout(context, attrs) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
designsystem 패키지 좋네요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우와 디자인시스템!!! 좋아요!
<com.going.presentation.designsystem.textview.ChartTextView | ||
android:id="@+id/tv_chart_first" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
캬 말안되네 진짜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
커스텀뷰 장인이십니다,,, 덕분에 참고하구 갑니당
import com.going.presentation.databinding.ViewChartTextviewBinding | ||
import com.going.ui.extension.setBulletPoint | ||
|
||
class ChartTextView(context: Context, attrs: AttributeSet) : ConstraintLayout(context, attrs) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우와 디자인시스템!!! 좋아요!
with(profileBoxInfo[0]) { | ||
setChartInfo(tvChartFirst, title, first, second, third) | ||
} | ||
with(profileBoxInfo[1]) { | ||
setChartInfo(tvChartSecond, title, first, second, third) | ||
} | ||
with(profileBoxInfo[2]) { | ||
setChartInfo(tvChartThird, title, first, second, third) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드가,,너무 간결해요 슨생님,,,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
진심////............................오늘도 보고 배웁니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다!!!!!!! 반영해서 저도 리팩할게욥~!!
with(profileBoxInfo[0]) { | ||
setChartInfo(tvChartFirst, title, first, second, third) | ||
} | ||
with(profileBoxInfo[1]) { | ||
setChartInfo(tvChartSecond, title, first, second, third) | ||
} | ||
with(profileBoxInfo[2]) { | ||
setChartInfo(tvChartThird, title, first, second, third) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
진심////............................오늘도 보고 배웁니다!
AuthState.SUCCESS -> navigateToScreen<DashBoardActivity>(listOf(Intent.FLAG_ACTIVITY_CLEAR_TOP)) | ||
AuthState.FAILURE -> navigateToScreen<SignInActivity>(listOf(Intent.FLAG_ACTIVITY_CLEAR_TOP)) | ||
AuthState.TENDENCY -> navigateToScreen<TendencySplashActivity>(listOf(Intent.FLAG_ACTIVITY_CLEAR_TOP)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요러케 쓰라는 말씀이시군요 알겟습니답!
⛳️ Work Description
📢 To Reviewers