[FEAT/#114] 프로필 조회 뷰 / 서버통신 구현 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Jan 15, 2024
app/src/main/AndroidManifest.xml
Outdated
Comment on lines
135
to
136
| android:name="com.going.presentation.setting.SettingActivity" | ||
| android:exported="false" | ||
| android:exported="true" |
| @@ -95,7 +95,11 @@ class EnterTripActivity : BaseActivity<ActivityEnterTripBinding>(R.layout.activi | |||
| } | |||
|
|
|||
| is UiState.Failure -> { | |||
| toast(getString(R.string.server_error)) | |||
| if (state.msg == "존재하지 않는 여행입니다.") { | |||
Comment on lines
74
to
88
| binding.run { | ||
| tvProfileName.text = name | ||
| tvProfileOneLine.text = intro | ||
|
|
||
| val profileImage = when (number) { | ||
| 0 -> R.drawable.img_profile_6 | ||
| 1 -> R.drawable.img_profile_1 | ||
| 2 -> R.drawable.img_profile_2 | ||
| 3 -> R.drawable.img_profile_4 | ||
| 4 -> R.drawable.img_profile_8 | ||
| 5 -> R.drawable.img_profile_5 | ||
| 6 -> R.drawable.img_profile_7 | ||
| 7 -> R.drawable.img_profile_3 | ||
| else -> R.drawable.img_profile_1 | ||
| } |
Marchbreeze
approved these changes
Jan 15, 2024
Comment on lines
+3
to
+4
| xmlns:app="https://schemas.android.com/apk/res-auto" | ||
| xmlns:tools="https://schemas.android.com/tools"> |
There was a problem hiding this comment.
혹시 프로필 뷰 툴바 타이틀이 "프로필 생성"이 맞나요? 생성하는 뷰는 아닌 것 같은데!
Comment on lines
30
to
31
|
|
||
|
|
Comment on lines
66
to
67
| if (errorCode == "e4043") { | ||
| _tripState.value = UiState.Failure(errorMessage) |
There was a problem hiding this comment.
에러코드같은 친구들도 아래에 const val로 따로 빼주는게 좋아요 ~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240115_195811_Gallery.mp4
Screen_Recording_20240115_174759_doorip.mp4
📢 To Reviewers