Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-C3 gives me a compile error #197

Closed
fa-yoshinobu opened this issue Dec 4, 2023 · 2 comments
Closed

ESP32-C3 gives me a compile error #197

fa-yoshinobu opened this issue Dec 4, 2023 · 2 comments

Comments

@fa-yoshinobu
Copy link

fa-yoshinobu commented Dec 4, 2023

I get the following error and cannot compile

.pio/libdeps/seeed_xiao_esp32c3/IoAbstraction/src/esp32/ESP32AnalogDevice.cpp:14:10: fatal error: driver/dac.h: No such file or directory
#include <driver/dac.h>
^~~~~~~~~~~~~~

I think the cause is the same as here
#161

I changed #ifndef CONFIG_IDF_TARGET_ESP32S3 to CONFIG_IDF_TARGET_ESP32C3 in ESP32AnalogDevice.cpp and the compilation was successful and tcMenu works.

Operation confirmed with Seeed Studio XIAO ESP32C3

@davetcc
Copy link
Collaborator

davetcc commented Dec 4, 2023

Ah yes, another board without the dac, I'll get that added to the header, thanks for confirming.

@davetcc davetcc self-assigned this Dec 4, 2023
@davetcc davetcc added this to the 4.1.0 milestone Mar 17, 2024
davetcc added a commit that referenced this issue Aug 4, 2024
#197 dac check improvement, use has include
@davetcc
Copy link
Collaborator

davetcc commented Aug 4, 2024

Fixed by PR to use include check instead of looking for flags.

@davetcc davetcc closed this as completed Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants