Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start): adding support for streaming using renderToReadableStream #1792

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

lithdew
Copy link
Contributor

@lithdew lithdew commented Jun 19, 2024

react-dom/server does not export renderToPipeableStream for JavaScript runtimes such as Bun.

@lithdew
Copy link
Contributor Author

lithdew commented Jun 19, 2024

CI appears to be failing due to some package exports that aren't touched in this PR + some unconfigured CI secrets.

Copy link

nx-cloud bot commented Jun 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e342405. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@SeanCassiere SeanCassiere changed the title feat(start): support streaming using renderToReadableStream fix(start): adding support for streaming using renderToReadableStream Jun 21, 2024
react-dom/server does not export renderToPipeableStream for JavaScript
runtimes such as Bun.
: 'OK',
headers: responseHeaders,
})
if (typeof ReactDOMServer.renderToReadableStream === 'function') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renderToReadableStream now has precedence over renderToPipeableStream, do we want this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it's either - or. I assumed that an implementation could have both.

@schiller-manuel schiller-manuel merged commit 765a5ac into TanStack:main Jun 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants